#defines split into lines, adds \ and spaces not needed

[mplexor]

format file:

---
#Language:        Cpp
BasedOnStyle:  LLVM

original single line:

#define grid float3 { 128, 128, 128 }

formats into:

#define grid                         \
 float3 { 128, 128, 128 }

[mkurdej]

Please provide the original code and the formatted result. Use markdown to make things easier to read.

[llvmbot]

@llvm/issue-subscribers-clang-format

[mplexor]

updated above. Thanks.

[mkurdej]

Thanks!

Note to self: It's apparently similar to #49164, but the fix (in review https://reviews.llvm.org/D116859) doesn't fix this bug. Also, it doesn't depend on ColumnLimit.

[llvmbot]

@llvm/issue-subscribers-bug

[mkurdej]

Minimal repro:

#define A {}

gets formatted to

#define A                                                                      \
  {}

[mplexor]

understood.
I have set column limit unbound (set 0), since all variable or trailing comment alignment features I found not useful.

Reason is purely due to use of variable spacing fonts like Verdana (not fixed spacing).
Fixed spacing based alignment will not work for those who use different font, alignment should be dynamically based on user's font in use (should be implemented part of editor rendering).

[mkurdej]

understood. I have set column limit unbound (set 0), since all variable or trailing comment alignment features I found not useful.

Reason is purely due to use of variable spacing fonts like Verdana (not fixed spacing). Fixed spacing based alignment will not work for those who use different font, alignment should be dynamically based on user's font in use (should be implemented part of editor rendering).

Not sure I understood what you mean here. clang-format has certainly nothing to do with the font :D.

[EugeneZelenko]

Please give developers time to address problems.

[LiamTyler]

And news on this? I stumbled upon this same thing today

[yous]

clang-format 18 partially fixes this, but still have some issues:

test.c:

#define foo bar { 1, 2 }
#define baz { 3, 4 }

$ clang-format --version
clang-format version 17.0.6 (https://github.com/ssciwr/clang-format-wheel 00700f257e3601a6ef0e714031c1dcef8077633f)
$ clang-format --style='{ColumnLimit: 0}' test.c
#define foo \
  bar { 1, 2 }
#define baz \
  { 3, 4 }

$ clang-format --version
clang-format version 18.1.5
$ clang-format --style='{ColumnLimit: 0}' test.c
#define foo \
  bar { 1, 2 }
#define baz {3, 4}