Release 0.0.116 #2427
Release 0.0.116 #2427
Conversation
| `UserConfig::manually_accept_inbound_channels` (#2368). | ||
| `BumpTransactionEventHandler` (#2089). Note that in order to do so you must | ||
| ensure you always have a reserve of available unspent on-chain funds to use | ||
| for CPFP. LDK currently makes no attempt to ensure this for you. |
There was a problem hiding this comment.
so who is going to use anchor outputs with 0.0.116, ldk-node ? i’ve looked around negotiate_anchors_zero_fee_htlc_tx and our CoinSelectionSource, we don’t really have documentation about how to manage fee-bumping reserves, what do you think if I write some simple, conservative and over-collateralized docs for the lightningdevkit website, or do we prefer security-related doc to be under the git tree ?
There was a problem hiding this comment.
If we're not going to include it as code documentation, we should at least reference to it somewhere. Happy to have you write something if you wish, I'm also working on a post for the LDK blog introducing anchor outputs and what things one should look out for while implementing it as a LDK user.
There was a problem hiding this comment.
If you think the docs are insufficient we should absolutely include them in the struct/config docs. I think many downstream users will use anchor in 116, both large custodial nodes but also ldk-node and ldk-sample.
There was a problem hiding this comment.
Happy to review the post for the LDK blog introducing anchor outputs when it’s ready (don’t hesitate to tag me on it). I’ll go to write more documentation, and I think it’s more appropriate to have them on the website (even if I know long-term it’s more maintenance work), as the very least we start to have a multitude of LDK deployment (mobile / large nodes / standard wallet) and generic documentation on fee-bumping reserves might be better suited here.
@ConorOkus Happy to have your thinking here, as you might have more visibility on downstream users, and if operational and safety documentation should go on the website or in struct/config docs, what is the best way to convey important information to the LDK users.
There was a problem hiding this comment.
Honestly, many of our downstream developers don't ever read the website. If documentation is only on the website I think ~everyone is going to miss it.
There was a problem hiding this comment.
I'd like to release 0.0.116 tomorrow. If you have any further documentation changes you'd like to see happen, we should make sure it happens by tomorrow early morning US time, at the very latest.
There was a problem hiding this comment.
I think I'll go for a doc/fee-bumping-reserve.md a la Linux and it can be copy-paste on the website if we wanna more docs there. Please go to land 0.0.116, I'll add them a posteriori during early 0.0.117 cycle.
While this is generally uneccessary as users set the `no-std` or `std` features on the `lightning` crate directly, having this allows `lightning-background-processor` to be built by itself without extra dep lines. Specifically, the bindings are moving to using the `-Z avoid-dev-deps` option, which now causes `lightning-background-processor` to fail to build directly.
TheBlueMatt
force-pushed
the
2023-07-cut-116
branch
from
b9ae58a to
a6989dd
Compare
|
Should be ready to go! |
TheBlueMatt
force-pushed
the
2023-07-cut-116
branch
from
a6989dd to
983f2c1
Compare
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2427 +/- ##
==========================================
- Coverage 90.24% 90.23% -0.01%
==========================================
Files 106 106
Lines 55817 55817
Branches 55817 55817
==========================================
- Hits 50374 50369 -5
- Misses 5443 5448 +5 ☔ View full report in Codecov by Sentry. |
Still a good chunk of bindings and other work to do before we can make this final, but hopefully this week. In the mean time followups for release note tweaks live here.