Skip to content

Add shebang to update scripts and fix Xcode references #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2013

Conversation

tiennou
Copy link
Contributor

@tiennou tiennou commented Jul 3, 2013

This allows editing the scripts in Xcode and automates the building of libgit (no need to drop to the CLI anymore).

@tiennou
Copy link
Contributor Author

tiennou commented Jul 3, 2013

I added the shebang because I'm have cmake installed through brew and Xcode wouldn't see it without it.

This allows access to the `ssh` transport if you have libssh2 installed (eg. using `brew`, so I'm only looking it `/usr/local/lib`). The libgit2 cmake script will detect it automatically, but since we're building static, it's our responsibility to have it.
@ghost ghost assigned jspahrsummers Jul 3, 2013
@jspahrsummers
Copy link
Contributor

Thanks!

jspahrsummers added a commit that referenced this pull request Jul 3, 2013
Add shebang to update scripts and fix Xcode references
@jspahrsummers jspahrsummers merged commit 0a235f4 into libgit2:master Jul 3, 2013
@tiennou
Copy link
Contributor Author

tiennou commented Jul 3, 2013

I see you found out the weak-linking doesn't work ? Same here ;-). ld complains if it can't find the weakly-linked library. I can't see an easy workaround, short of adding libssh2 as a dependency... Your call !

@jspahrsummers
Copy link
Contributor

A required dependency that big would be unfortunate. :\

Maybe we can fix up libgit2's weak linking or add our own?

@tiennou
Copy link
Contributor Author

tiennou commented Jul 3, 2013

The problem is that we're linking libgit2 statically, which means it becomes Objective-Git responsibility to link against whatever libgit2 requires (there's already libz, libcrypto & libssl, which are "pretty big" but system-provided). So unless we switch to a "real" dynamic library (which won't fly on iOS) and make the weak-linking happen in the right place I don't think it's possible. And it still doesn't take care of the fact that libssh2 is now a required thing for linking even when weak-linked — but it shouldn't matter at runtime (a.k.a on the computer you'll install the application that uses Objective-Git).
A complete hack would be to have another target "Objective-Git-OSX + ssh". But then you have to have another one for iOS :-(.

For now, I'll keep that thing locally for working on fetching remotes (and discovering bugs ;-)).

@jspahrsummers
Copy link
Contributor

HTTPS and git:// fetching should work without libssh2. In any case, I'm happy to reconsider this in the context of a PR to add fetching support.

@tiennou
Copy link
Contributor Author

tiennou commented Jul 3, 2013

Not until libgit2/libgit2#1700 ;-)

@tiennou tiennou mentioned this pull request Sep 11, 2013
phatblat pushed a commit to phatblat/objective-git that referenced this pull request Sep 13, 2014
Add shebang to update scripts and fix Xcode references
@jspahrsummers jspahrsummers removed their assignment May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants