-
Notifications
You must be signed in to change notification settings - Fork 281
Add shebang to update scripts and fix Xcode references #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I added the shebang because I'm have |
This allows access to the `ssh` transport if you have libssh2 installed (eg. using `brew`, so I'm only looking it `/usr/local/lib`). The libgit2 cmake script will detect it automatically, but since we're building static, it's our responsibility to have it.
Thanks! |
Add shebang to update scripts and fix Xcode references
I see you found out the weak-linking doesn't work ? Same here ;-). |
A required dependency that big would be unfortunate. :\ Maybe we can fix up libgit2's weak linking or add our own? |
The problem is that we're linking libgit2 statically, which means it becomes Objective-Git responsibility to link against whatever libgit2 requires (there's already libz, libcrypto & libssl, which are "pretty big" but system-provided). So unless we switch to a "real" dynamic library (which won't fly on iOS) and make the weak-linking happen in the right place I don't think it's possible. And it still doesn't take care of the fact that libssh2 is now a required thing for linking even when weak-linked — but it shouldn't matter at runtime (a.k.a on the computer you'll install the application that uses Objective-Git). For now, I'll keep that thing locally for working on fetching remotes (and discovering bugs ;-)). |
HTTPS and |
Not until libgit2/libgit2#1700 ;-) |
Add shebang to update scripts and fix Xcode references
This allows editing the scripts in Xcode and automates the building of libgit (no need to drop to the CLI anymore).