Skip to content

Improve naming of CI jobs. #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 28, 2023
Merged

Improve naming of CI jobs. #209

merged 4 commits into from
Mar 28, 2023

Conversation

mpaulucci
Copy link
Collaborator

Changelog:

  • Improved naming of CI jobs
  • Merged fmt and clippy into lint.

@mpaulucci mpaulucci marked this pull request as ready for review March 23, 2023 15:12
@mpaulucci mpaulucci requested review from a team, schouhy and ajgara as code owners March 23, 2023 15:12
@codecov-commenter
Copy link

Codecov Report

Merging #209 (7441f99) into main (ccd9bb2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   92.15%   92.15%           
=======================================
  Files          66       66           
  Lines        7164     7164           
=======================================
  Hits         6602     6602           
  Misses        562      562

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

IAvecilla
IAvecilla approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@IAvecilla IAvecilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! some minor details

ilitteri
ilitteri reviewed Mar 23, 2023
View reviewed changes
@mpaulucci mpaulucci enabled auto-merge March 27, 2023 11:02
@IAvecilla IAvecilla requested a review from ilitteri March 27, 2023 20:06
@mpaulucci mpaulucci added this pull request to the merge queue Mar 28, 2023
Merged via the queue into main with commit e0689ab Mar 28, 2023
@mpaulucci mpaulucci deleted the improve-ci branch March 28, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrchatruc jrchatruc jrchatruc approved these changes

@IAvecilla IAvecilla IAvecilla approved these changes

@ilitteri ilitteri ilitteri approved these changes

@schouhy schouhy Awaiting requested review from schouhy

@ajgara ajgara Awaiting requested review from ajgara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mpaulucci @codecov-commenter @jrchatruc @IAvecilla @ilitteri