Added fix for instance of Echo that have a prefix (created with `Group()... #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p()` method). The `URI()` method should return prefix plus the calculated string.
Closed
|
Note: To make this build pass, we need to remove the two tests: if e.URI(getGroups) != "/groups" {
t.Error("uri should be /groups")
}
if e.URI(getGroup, "1") != "/groups/1" {
t.Error("uri should be /groups/1")
}The question is should that work from an API perspective or not... |
vishr
added a commit
that referenced
this pull request
May 31, 2015
Signed-off-by: Vishal Rana <[email protected]>
vishr
added a commit
that referenced
this pull request
May 31, 2015
Signed-off-by: Vishal Rana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fix for instance of Echo that have a prefix (created with
Group() method). TheURI()` method should return prefix plus the calculated string.This is related to /pull/36, I closed that pull request because this one contains a fix. This is also relates to #12