-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
AddingPowerSupport_&_CISupport #1662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adding power support
Codecov Report
@@ Coverage Diff @@
## master #1662 +/- ##
==========================================
- Coverage 85.28% 83.78% -1.51%
==========================================
Files 28 28
Lines 2216 1906 -310
==========================================
- Hits 1890 1597 -293
+ Misses 212 195 -17
Partials 114 114
Continue to review full report at Codecov.
|
If ll the checks are successful, Can you please Approve? |
Can you Please check & approve this PR? It's been open from some time., |
Herewith Checking if you have any further questions on this., Thank you!! |
A gentle nudge, Checking if you have any questions on this PR!! |
I guess nudge every day, won't help much to speed up the review. It's more likely achieving the opposite. I'm not sure we gain much from running the CI on other plattforms, as we are only using Go without any C libs. |
@lammel yeah - good point - @santosh653 try to give people at least a week before any reminder, and maybe one after a month just to see if there is an active maintainer. @lammel one advantage of testing ppc64le on top of tree validates that all of the underlying components are present, that the go compiler doesn't have any corner cases that your code drives, and announces if anyone adds any non-independent code. The time should be free (with new Travis CI policy, you may have to ask for more credits but that is free and mostly easy). |
@lammel,. checking if you have any further queries on this? |
Lets see if it works out. |
adding power support.
Adding power support ppc64le with Continues Integration/testing so that code remains architecture independent.
This is part of the Ubuntu distribution for ppc64le. This helps us simplify testing later when distributions are re-building and re-releasing. For more info tag @gerrith3.
The build is successful on both arch: amd64/ppc64le, please find the Travis Link below.
https://travis-ci.com/github/santosh653/echo
Please let me know if you need any further details? or if I am missing any?
Thank You !!