Skip to content

Run Test Workflow only if Go code was changed #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Conversation

pofl
Copy link
Contributor

@pofl pofl commented Sep 12, 2020

I've never worked with GitHub actions so I hope this has been set up correctly. What do you think about this change?

@codecov
Copy link

codecov bot commented Sep 12, 2020

Codecov Report

Merging #1637 (31599cf) into master (28ec3f7) will decrease coverage by 0.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1637      +/-   ##
==========================================
- Coverage   85.28%   84.35%   -0.94%     
==========================================
  Files          28       28              
  Lines        2216     1911     -305     
==========================================
- Hits         1890     1612     -278     
+ Misses        212      189      -23     
+ Partials      114      110       -4     
Impacted Files Coverage Δ
middleware/proxy.go 60.97% <0.00%> (-5.37%) ⬇️
middleware/method_override.go 80.95% <0.00%> (-3.67%) ⬇️
middleware/redirect.go 85.00% <0.00%> (-3.24%) ⬇️
context.go 86.59% <0.00%> (-3.13%) ⬇️
middleware/basic_auth.go 65.62% <0.00%> (-2.95%) ⬇️
middleware/util.go 88.88% <0.00%> (-1.74%) ⬇️
response.go 85.18% <0.00%> (-1.66%) ⬇️
middleware/cors.go 77.94% <0.00%> (-1.52%) ⬇️
echo.go 84.75% <0.00%> (-1.18%) ⬇️
middleware/key_auth.go 66.66% <0.00%> (-1.13%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28ec3f7...31599cf. Read the comment docs.

Copy link
Contributor

@lammel lammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Please also add go.mod and for tests the _fixture dir to ensure tests are rerun also when fixtures change. Both change rarely.

@pofl pofl requested a review from lammel November 11, 2020 09:24
@lammel
Copy link
Contributor

lammel commented Nov 11, 2020

Guess we'll see if it works out as expected.
Thanks @pofl

@lammel lammel merged commit 7a90304 into labstack:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants