-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix multi level match any routes #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi level match any routes #1413
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1413 +/- ##
==========================================
+ Coverage 84.09% 84.36% +0.27%
==========================================
Files 27 27
Lines 2068 2079 +11
==========================================
+ Hits 1739 1754 +15
+ Misses 214 212 -2
+ Partials 115 113 -2
Continue to review full report at Codecov.
|
The travis CI error is not related to this PR is seems.
Let me know if a should push again. |
c4bc098
to
ccf6f1a
Compare
Rebased on master (v4.1.11) now. An additional issue has been fixed in route insert, which did not correctly update the parent node on node split (which resolves an issue with adding routes in the wrong order, causing a root-node split, tests added for that case). |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
…otel-at/echo into bugfix/1412-route-matchany-multilevel
Please re-open this. We need this merged. |
Thank you very much! |
This is a pull request for issue #1412 which probably also fixes #1406 .
The benchmarks also indicate a slight improvement for the route tests (although that was not intential). So this should probably be verified elsewhere too.
As a side-effect also a small issue for the router not returning the correct remaining path in c.Param("*") with overlapping any routes has been fixed (and a test added)
The route tests have also been improved which can also be provided as part of this PR are separately.