[FIX] Simplify dep fetching #1062
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1062 +/- ##
=======================================
Coverage 78.92% 78.92%
=======================================
Files 27 27
Lines 1879 1879
=======================================
Hits 1483 1483
Misses 282 282
Partials 114 114Continue to review full report at Codecov.
|
|
@vishr any updates? |
|
@im-kulikov I was curious to know what is the reasoning for fetching a specific version for |
|
This is required to commit a specific version. |
|
Fair enough. |
|
@vishr This simplification assumes that everyone is using Windows, which is not the case. Going further, Windows and OSX users will need to handle deps themselves, which seems like a regression. |
|
@alexaandru explain? |
Enhancements:
Implemented Response#After()
Dynamically add/remove proxy targets
Rewrite rules for proxy middleware
Add ability to extract key from a form field
Implemented rewrite middleware
Adds a separate flag for the 'http/https server started on' message (#1043)
Applied a little DRY to the redirect middleware (#1053) and tests (#1055)
Simplify dep fetching (#1062)
Add custom time stamp format #1046 (#1066)
Update property name & default value & comment about custom logger
Add X-Requested-With header constant
Return error of context.File in c.contentDisposition
Updated deps
Updated README.md
Fixes:
Fixed Response#Before()
Fixed #990
Fix href url from armor to echo (#1051)
Fixed #1054
Fixed #1052, dropped param alias feature
Avoid redirect loop in HTTPSRedirect middleware (#1058)
Fix deferring body close in middleware/compress test (#1063)
Cleanup code (#1061)
FIX - We must close gzip.Reader, only if no error (#1069)
Fix formatting (#1071)
Can be a fix for auto TLS
|
@im-kulikov OSX is unix-like, and so is Windows with Cygwin installed. Neither of them will be able to run |
|
@alexaandru oh.. I understand.. |
|
I can make research and fix this |
|
It seems that if we just use the provided install instructions, that is cross platform friendly: |
No description provided.