broken auto-decoding urlencoded named path parameters

[mr-tron]

Description

Checklist

• [ +] Dependencies installed
• [ +] No typos
• [ +] Searched existing issues and docs

Expected behaviour

Actual behaviour

c.Param("s") don't decode param if it encoded with urlencode

Steps to reproduce

Working code to debug

package main
import (
"github.com/labstack/echo"
"fmt"
)

func handler(c echo.Context) error {
  s := c.Param("s")
  fmt.Println(s)
return nil
}
func main() {
e := echo.New()
e.GET("/:s", handler)
e.Start(":9090")
}

curl 'http://localhost:9090/ыыыы'
in stdout you can see %D1%8B%D1%8B%D1%8B%D1%8B (not ыыыы as expected)

Version/commit

1f0bae3 - in this version worked
I didn't search commit there it was broken.

[mr-tron]

i think #839 is the same problem

[vishr]

Related: #766

[vishr]

@mr-tron This has been discussed many times in the above mentioned issues and finally we decided to move the unescaping logic for any kind of parameter outside the framework. So in your case you can simply unescape the parameter using url.QueryUnescape(c.Param("s")). Don't hesitate to continue the discussion.

[vishr]

Okay, we got it resolved in b2430fc.