Close file descriptor returned by request.FormFile (#1411)

WhileLoop · vishr · commit 754b44989fd0 · 2019-10-24T11:52:14.000-07:00
diff --git a/context.go b/context.go
@@ -347,7 +347,8 @@ func (c *context) FormParams() (url.Values, error) {
 }
 
 func (c *context) FormFile(name string) (*multipart.FileHeader, error) {
-	_, fh, err := c.request.FormFile(name)
+	f, fh, err := c.request.FormFile(name)
+	defer f.Close()
 	return fh, err
 }
 

Original file line number	Diff line number	Diff line change
`@@ -347,7 +347,8 @@ func (c *context) FormParams() (url.Values, error) {`
`347`	`347`	`}`
`348`	`348`
`349`	`349`	`func (c context) FormFile(name string) (multipart.FileHeader, error) {`
`350`		`- _, fh, err := c.request.FormFile(name)`
	`350`	`+ f, fh, err := c.request.FormFile(name)`
	`351`	`+ defer f.Close()`
`351`	`352`	`return fh, err`
`352`	`353`	`}`
`353`	`354`