reset p.values to echo.maxParam (#1429)

Mark Smith · vishr · commit ee6618e8319c · 2019-10-24T10:48:56.000-07:00
* reset p.values to echo.maxParam
* Update context.go

How about just reset the values?
diff --git a/context.go b/context.go
@@ -609,5 +609,7 @@ func (c *context) Reset(r *http.Request, w http.ResponseWriter) {
 	c.path = ""
 	c.pnames = nil
 	// NOTE: Don't reset because it has to have length c.echo.maxParam at all times
-	// c.pvalues = nil
+	for i := 0; i < *c.echo.maxParam; i++ {
+		c.pvalues[i] = ""
+	}
 }
diff --git a/go.sum b/go.sum
@@ -26,6 +26,7 @@ golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn
 golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
 golang.org/x/sys v0.0.0-20190222072716-a9d3bda3a223/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
 golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
+golang.org/x/sys v0.0.0-20190813064441-fde4db37ae7a h1:aYOabOQFp6Vj6W1F80affTUvO9UxmJRx8K0gsfABByQ=
 golang.org/x/sys v0.0.0-20190813064441-fde4db37ae7a/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/text v0.3.0 h1:g61tztE5qeGQ89tm6NTjjM9VPIm088od1l6aSorWRWg=
 golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=

Original file line number	Diff line number	Diff line change
`@@ -609,5 +609,7 @@ func (c context) Reset(r http.Request, w http.ResponseWriter) {`
`609`	`609`	`c.path = ""`
`610`	`610`	`c.pnames = nil`
`611`	`611`	`// NOTE: Don't reset because it has to have length c.echo.maxParam at all times`
`612`		`- // c.pvalues = nil`
	`612`	`+ for i := 0; i < *c.echo.maxParam; i++ {`
	`613`	`+ c.pvalues[i] = ""`
	`614`	`+ }`
`613`	`615`	`}`