Skip to content

WIP: Update generated code, throw on 401 errors #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP: Update generated code, throw on 401 errors #493

wants to merge 1 commit into from

Conversation

brendandburns
Copy link
Contributor

Fixes #491

cc @tg123

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 7, 2020
@brendandburns brendandburns changed the title Update generated code, throw on 401 errors WIP: Update generated code, throw on 401 errors Oct 7, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2020
@brendandburns
Copy link
Contributor Author

Hrm, it looks like this reverts V1Patch to object I think that shouldn't happen, I'll need to fix that before we can merge this.

@tg123
Copy link
Member

tg123 commented Oct 7, 2020

swagger.json changed?

@gaurav137 gaurav137 mentioned this pull request Oct 9, 2020
Closed
@tg123 tg123 mentioned this pull request Oct 26, 2020
Merged
@brendandburns
Copy link
Contributor Author

Closing this since #505 merged and has the same changes.

@k8s-ci-robot
Copy link
Contributor

@brendandburns: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krabhishek8260 krabhishek8260 Awaiting requested review from krabhishek8260

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No error returned when credentials are incorrect
4 participants
@brendandburns @k8s-ci-robot @tg123 @brendanburns