fix: Million.js #772 issue #1216
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krausest
reviewed
Mar 26, 2023
There was a problem hiding this comment.
Looks good to me as far as #772 is concerned.
Not necessary this time, but it would be cool if main.js would be moved into a dist folder (and removes from git).
I'm not sure whether I should approve or you want to approve the PR. Please remove the draft state if ready.
|
Got it. Let me finish some things up for v2.1.1 so the release + pr is ready to go. Thanks for checking in |
|
Going to reopen a new PR with the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues laid out in #772, specifically with the manual patching in select and remove benchmarks.