[MP1] Add RPMsg virtual serial protocol support (VirtIOSerial) Update proposal #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR propose some update after a review of your PR:
stm32duino#766
Major update proposed:
Note: I stick to Arduino official definition:
https://www.arduino.cc/reference/en/language/functions/communication/serial/peek/
"That is, successive calls to peek() will return the same character, as will the next call to read()."
Even if not currently used, it is better to have muti instance support for this C++ class.
I tested those changes with the sketch you proposed, and it work fine.
I just change this line to receive in minicom the same ASCII characters that has been send.
Serial.print( (char) Serial.read());