Skip to content

Add more ways to copy the currently opened file #12870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 17, 2022
Merged

Add more ways to copy the currently opened file #12870

merged 7 commits into from
Aug 17, 2022

Conversation

peytondmurray
Copy link
Contributor

@peytondmurray peytondmurray commented Jul 27, 2022

References

Closes #12099.

Code changes

  • Adds a new docmanager:duplicate command for duplicating a file

User-facing changes

Adds 3 new ways to duplicate the currently opened file to the UI:

  • Through the context menu that opens when right clicking on an opened tab
  • Via a new entry in the File menu
  • Using the command palette

which are the 3 ways of duplicating an opened file proposed in the original issue.

Context menu entry:
image

File menu entry:
image

Command palette entry:
palette

Backwards-incompatible changes

None

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@peytondmurray peytondmurray changed the title [WIP] Add more ways to copy the currently opened file Add more ways to copy the currently opened file Jul 27, 2022
@peytondmurray peytondmurray marked this pull request as ready for review July 27, 2022 23:04
@jtpio jtpio added this to the 4.0.0 milestone Jul 28, 2022
@krassowski
Copy link
Member

bot please update snapshots

@krassowski
Copy link
Member

Two of the screenshots got updated but should not have:

  • debugger-kernel-documentation-linux.png
  • file-formats-nteract-vdom-documentation-linux.png

@peytondmurray I will merge your branch with master and re-run snapshot bot to see if these were due to something which was already fixed.

@peytondmurray
Copy link
Contributor Author

👍 Thanks @krassowski, it looks like that did the trick!

@krassowski
Copy link
Member

krassowski commented Aug 7, 2022

Well, c3f6667 did it. Surprisingly the visual regression tests for documentation work about as well with and without that commit. I guess that it could be because of lenient retry settings: the snapshots are taken by the bot when the kernel is still busy / SVG comic has not finished loading and they pass the regression tests in one of the allowed retries; the tracked snapshots are taken after loading finished and they also pass the tests in one of the retries.

Edit: I left my feedback in the original issue: #12099 (comment).

@fcollonval
Copy link
Member

bot please update galata snapshots

@fcollonval
Copy link
Member

Kicking CI

@fcollonval fcollonval closed this Aug 10, 2022
@fcollonval fcollonval reopened this Aug 10, 2022
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcollonval fcollonval merged commit fbbfc54 into jupyterlab:master Aug 17, 2022
@peytondmurray peytondmurray deleted the make-copy-file-easier branch September 30, 2022 00:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easier copying of the current file
4 participants