JupyterLab 3.0

[khwj]

• Upgrades to JupyterLab 3.0
• Most changes are from the upgrade script
• Fix no initializer errors due to stricter null checks
• Fix ValueError: The extension "@jupyterlab/github" does not yet support the current version of JupyterLab. #111

[beenje]

The errorPanel isn't working: Unhandled Promise Rejection: NotFoundError: The object can not be found here. on RemoveChild.

If you know how to fix it, I'm interested :-)
I have the same issue for the jupyterlab-gitlab extension.

[jingw222]

Has the issue been suspended? Still not fixed as of yet.

Extension Installation Error
An error occurred installing <code>@jupyterlab/github</code>.

Error message:

The extension "@jupyterlab/github" does not yet support the current version of JupyterLab.


Conflicting Dependencies:
JupyterLab                  Extension       Package
>=3.0.10 <3.1.0             >=2.0.0 <3.0.0  @jupyterlab/application
>=3.0.8 <3.1.0              >=2.0.0 <3.0.0  @jupyterlab/apputils
>=5.0.6 <5.1.0              >=4.0.0 <5.0.0  @jupyterlab/coreutils
>=3.0.10 <3.1.0             >=2.0.0 <3.0.0  @jupyterlab/docmanager
>=3.0.10 <3.1.0             >=2.0.0 <3.0.0  @jupyterlab/filebrowser
>=6.0.8 <6.1.0              >=5.0.0 <6.0.0  @jupyterlab/services
>=3.0.5 <3.1.0              >=2.0.0 <3.0.0  @jupyterlab/settingregistry
>=3.0.7 <3.1.0              >=2.0.0 <3.0.0  @jupyterlab/ui-components

[jhgoebbert]

The errorPanel isn't working: Unhandled Promise Rejection: NotFoundError: The object can not be found here. on RemoveChild.

If you know how to fix it, I'm interested :-)
I have the same issue for the jupyterlab-gitlab extension.

The following line
const listing = (this._browser.layout as PanelLayout).widgets[2];
can be found at these four places.
https://github.com/jupyterlab/jupyterlab-github/blob/v2.0.0/src/browser.ts#L149
https://github.com/jupyterlab/jupyterlab-github/blob/v2.0.0/src/browser.ts#L228
https://github.com/jupyterlab/jupyterlab-github/blob/v2.0.0/src/browser.ts#L241
https://github.com/jupyterlab/jupyterlab-github/blob/v2.0.0/src/browser.ts#L252

It assumes, that the 3rd widget (=[2]) of PanelLayout ist listing.
This was the case until JupyterLab 2.x for its FileBrowser:
https://github.com/jupyterlab/jupyterlab/blob/2.3.x/packages/filebrowser/src/browser.ts#L101

But now the widget listing is the 4th one (=[3]), because _filenameSearcher is new.
https://github.com/jupyterlab/jupyterlab/blob/3.1.x/packages/filebrowser/src/browser.ts#L129

Hence, I expect it now should be
const listing = (this._browser.layout as PanelLayout).widgets[3];

[jhgoebbert]

I checked, if [2] -> [3] fixes the errorPanel-bug and it does. 👍

[krassowski]

listing is no longer private (only protected), but since this extension only uses the HTML node to focus on it, it could just:

const LISTING_CLASS = 'jp-FileBrowser-listing';
this._browser.node.querySelector('.' + LISTING_CLASS).focus()

[shadow150519]

has this problem been fixed yet ? i also encounter the same problem

Extension Installation Error
An error occurred installing <code>@jupyterlab/github</code>.

Error message:

The extension "@jupyterlab/github" does not yet support the current version of JupyterLab.


Conflicting Dependencies:
JupyterLab                  Extension      Package
>=3.1.3 <3.2.0              >=2.0.0 <3.0.0 @jupyterlab/application
>=3.1.3 <3.2.0              >=2.0.0 <3.0.0 @jupyterlab/apputils
>=5.1.3 <5.2.0              >=4.0.0 <5.0.0 @jupyterlab/coreutils
>=3.1.3 <3.2.0              >=2.0.0 <3.0.0 @jupyterlab/docmanager
>=3.1.3 <3.2.0              >=2.0.0 <3.0.0 @jupyterlab/filebrowser
>=6.1.3 <6.2.0              >=5.0.0 <6.0.0 @jupyterlab/services
>=3.1.3 <3.2.0              >=2.0.0 <3.0.0 @jupyterlab/settingregistry
>=3.1.3 <3.2.0              >=2.0.0 <3.0.0 @jupyterlab/ui-components

[jhgoebbert]

Thanks to @beenje the issue got fixed for jupyterlab-gitlab (https://pypi.org/project/jupyterlab-gitlab) but not jupyterlab-github.

[fcollonval]

Small comment on the new style structure.

And the index.css file should not be imported any longer in src/index.ts

https://github.com/khwj/jupyterlab-github/blob/6a25e3c02cb2032ea4e9c3c79777e6ff5c4b9057/src/index.ts#L22

[fcollonval]

All the styles must be moved to base.css

[krassowski]

Is this documented somewhere?

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

[krassowski]

Thank you @khwj.

[immerrr]

Just hit this issue.

@krassowski Would it be possible to have a version including this fix published to NPM? Or is there an easy way to install this extension from source?

[krassowski]

Yes, I will publish a new release tomorrow.

[krassowski]

The new versions should be up on PyPI and npm. I updated readme to reflect that prebuilt extension is shipped in the PyPI version and updated references from notebook to jupyter-server.