Jtratner datetime index insert non datetimes (fixes pandas GH5819) #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix pandas-dev#5819
allow concat in the indexes of a string to a datetime (converts to object; you may want to add a test
if you are concatting something like '20010101', e.g. a string that looks like a date)...I think it should NOT convert it though...fraught with too much risk of getting it wrong
that is why float/int are not allowed...because the datetimeindex is backed by ints...too much ambiguity here
rather raise than silently pass it thru
the string case is oko thought I think
IIRC @cpcloud had this issue when concating a PeriodIndex and a DatetimeIndex..not sure what happened with that though