Skip to content

Jtratner datetime index insert non datetimes (fixes pandas GH5819) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jreback
Copy link

@jreback jreback commented Jan 2, 2014

This should fix pandas-dev#5819

allow concat in the indexes of a string to a datetime (converts to object; you may want to add a test
if you are concatting something like '20010101', e.g. a string that looks like a date)...I think it should NOT convert it though...fraught with too much risk of getting it wrong

that is why float/int are not allowed...because the datetimeindex is backed by ints...too much ambiguity here
rather raise than silently pass it thru

the string case is oko thought I think

IIRC @cpcloud had this issue when concating a PeriodIndex and a DatetimeIndex..not sure what happened with that though

@jtratner
Copy link
Owner

jtratner commented Jan 2, 2014

I cherry-picked your commit on top of the branch so there wouldn't be a weird merge commit in the history - thanks!

@jtratner jtratner closed this Jan 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants