Skip to content

Create a branch that uses hard exceptions instead #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 20, 2025
Merged

Create a branch that uses hard exceptions instead #45

merged 8 commits into from
Jan 20, 2025

Conversation

TotalTechGeek
Copy link
Member

Just an experiment for @JTeeuwissen

@coveralls
Copy link

coveralls commented Jan 20, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12876193339

Details

  • 78 of 80 (97.5%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 93.475%
Changes Missing Coverage Covered Lines Changed/Added Lines %
defaultMethods.js 75 77 97.4%
Totals Coverage Status
Change from base Build 12872899403: -0.2%
Covered Lines: 975
Relevant Lines: 995
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12873876881

Details

  • 34 of 34 (100.0%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.0%) to 92.717%
Files with Coverage Reduction New Missed Lines %
defaultMethods.js 2 92.22%
utilities/downgrade.js 3 41.18%
Totals Coverage Status
Change from base Build 12872899403: -1.0%
Covered Lines: 968
Relevant Lines: 993
💛 - Coveralls

@TotalTechGeek TotalTechGeek marked this pull request as ready for review January 20, 2025 21:56
@TotalTechGeek TotalTechGeek merged commit 9f93d94 into master Jan 20, 2025
6 checks passed
@TotalTechGeek TotalTechGeek deleted the proposal/hard-errors branch January 20, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TotalTechGeek @coveralls