Skip to content

Fix function check in var method #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Fix function check in var method #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4880c0
failing test
horacio-penya Oct 8, 2024
853f0dd
fix function check: context is already at originalcontext[key]
horacio-penya Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions async.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,6 +826,17 @@ modes.forEach((logic) => {
).toBe(null)
})

test('allow access to objects named as their methods', async () => {
expect(
await logic.run(
{
var: 'toString'
},
{toString: 'hello'}
)
).toBe("hello")
})

test('allow access to functions on objects when enabled', async () => {
logic.allowFunctions = true
expect(
Expand Down
2 changes: 1 addition & 1 deletion defaultMethods.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ const defaultMethods = {
return notFound
}
}
if (engine.allowFunctions || typeof (context && context[key]) !== 'function') {
if (engine.allowFunctions || typeof context !== 'function') {
return context
}
return null
Expand Down
Loading