Skip to content

benchmarks: add benchmark for Stream #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2020
Merged

benchmarks: add benchmark for Stream #439

merged 1 commit into from
Apr 29, 2020

Conversation

robfig
Copy link
Contributor

@robfig robfig commented Jan 17, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #439 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
- Coverage   86.46%   86.42%   -0.04%     
==========================================
  Files          41       41              
  Lines        5106     5106              
==========================================
- Hits         4415     4413       -2     
- Misses        555      557       +2     
  Partials      136      136
Impacted Files Coverage Δ
reflect_struct_decoder.go 81.09% <0%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c900e...a54d350. Read the comment docs.

@robfig
Copy link
Contributor Author

robfig commented Jan 18, 2020

There is no benchmark covering Stream operation, where I believe I found a performance bug. This commit adds a benchmark in preparation for a patch to fix #438

@AllenX2018 AllenX2018 merged commit a54d350 into json-iterator:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants