Updated DRF and Python version combinations #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to test the basic support of this combination. Eventually the test matrix will be expanded out to cover Python 3.5 support in all DRF versions that support it.
|
@kevin-brown I'd definitely drop anything pre Django 1.11 at this point and perhaps just test against latest stable DRF release. That would simplify the matrix considerably. |
tox-travis allows us to not have to manage a tox matrix with 70+ different combinations and instead has us only define the combinations in a single location.
Tox 3.0 does not support Python 3.3 but it supports up to Python 3.6.
Looks like having a < in the command messes things up, which sorta makes sense.
Not going to fight Tox to make it work on Python 3.3, instead let's just drop it. This also updates pytest-django to support Python 3.5.
The versions of DRF for these Django versions should also support Python 3.5.
Not all versions of DRF supported Python 3.5, so these are going down as a different list of envrionments because of that.
This is no longer needed now that we don't have 100 different combinations
This adds DRF 3.9 to the Tox environment list.
kevin-brown
changed the title
|
Once again, no code changes were required to support the newer versions (latest DRF, latest Django, Python up to 3.6). I dropped support for Django 1.6/1.7 and Python 3.3 because it made it easier to set up the Tox matrix. I also switched to tox-travis to make specifying that matrix in Travis much less painful. |
|
@kevin-brown thank you! 🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be supported out of the box, but let's find out...
By the end of this we are going to be at over a hundred different supported combinations. We may want to look into dropping really old combinations from the testing matrix, or cutting some of the middle versions since we don't have much (if any) special casing going on.