Skip to content

XMLRenderer tries to import StringIO from rest_framework.compat #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brandoncazander opened this issue Jan 28, 2015 · 1 comment · Fixed by #4
Closed

XMLRenderer tries to import StringIO from rest_framework.compat #3

brandoncazander opened this issue Jan 28, 2015 · 1 comment · Fixed by #4
Labels
bug

Comments

@brandoncazander
Copy link
Contributor

When trying to use XMLRenderer, an ImportError is raised:

ImportError: cannot import name StringIO

The custom StringIO has been removed from rest_framework.compat.
@jpadilla jpadilla added the bug label Jan 28, 2015
@jpadilla
Copy link
Owner

@brandoncazander yeah good catch. Can you put a PR together to fix it? If not I'll try to get to it later today or tomorrow.

brandoncazander added a commit to brandoncazander/django-rest-framework-xml that referenced this issue Jan 28, 2015
@brandoncazander
Don't use rest_framework.compat for StringIO, smart_text. Fixes jpadi…
b199688 
…lla#3
brandoncazander pushed a commit to brandoncazander/django-rest-framework-xml that referenced this issue Jan 28, 2015
Also don't import rest_framework.compat in tests. jpadilla#3
c40e944
@brandoncazander brandoncazander mentioned this issue Jan 28, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@jpadilla @brandoncazander