-
Notifications
You must be signed in to change notification settings - Fork 127
Add SCSS Coding Standards #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should we also list LESS here as well? |
I can't see how we can add coding standards for LESS as the J3.x files are absolutely diabolical and we don't use them in 4.0 |
According to how I read it, the existing standards suggest the LESS files should have followed the CSS standards and the nesting like SCSS but with no enforcement of the standards, no one followed them. |
I'm not sure here. The coding standards with scss are only valid for 4.0 for 3.x we still have LESS as default so we can apply this change before 4.0 is live 😄 |
Considering LESS will be alive and supported in the 3.x branch for like the next 2 years we should include that in the standard even if the files are not actually compliant with the expected code style. |
Once the LESS standards have been applied, someone will then have to apply those standards. Whoever does that....well all I can say is good luck and enjoy. |
@C-Lodder Would you be able to redo this PR against the master branch? We've dropped the |
sure, will do tomorrow |
This PR adds the coding standards for SCSS, in addition to some minor tweaks for CSS