Skip to content

Add SCSS Coding Standards #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add SCSS Coding Standards #146

wants to merge 3 commits into from

Conversation

C-Lodder
Copy link
Member

This PR adds the coding standards for SCSS, in addition to some minor tweaks for CSS

@photodude
Copy link
Contributor

Should we also list LESS here as well?

@C-Lodder
Copy link
Member Author

C-Lodder commented Jan 26, 2017

I can't see how we can add coding standards for LESS as the J3.x files are absolutely diabolical and we don't use them in 4.0

@photodude
Copy link
Contributor

photodude commented Jan 26, 2017

According to how I read it, the existing standards suggest the LESS files should have followed the CSS standards and the nesting like SCSS

but with no enforcement of the standards, no one followed them.

@zero-24
Copy link
Contributor

zero-24 commented Feb 5, 2017

I'm not sure here. The coding standards with scss are only valid for 4.0 for 3.x we still have LESS as default so we can apply this change before 4.0 is live 😄

@photodude
Copy link
Contributor

Considering LESS will be alive and supported in the 3.x branch for like the next 2 years we should include that in the standard even if the files are not actually compliant with the expected code style.

@C-Lodder
Copy link
Member Author

C-Lodder commented Feb 5, 2017

Once the LESS standards have been applied, someone will then have to apply those standards. Whoever does that....well all I can say is good luck and enjoy.

@mbabker
Copy link
Contributor

mbabker commented Feb 16, 2017

@C-Lodder Would you be able to redo this PR against the master branch? We've dropped the gh-pages branch and using GitHub pages for the manual in favor of showing it through a component on https://developer.joomla.org.

@C-Lodder
Copy link
Member Author

sure, will do tomorrow

@C-Lodder
Copy link
Member Author

@mbabker done: #155

@C-Lodder C-Lodder closed this Feb 17, 2017
@C-Lodder C-Lodder deleted the css branch February 17, 2017 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants