Allow chaining together multiple dataloader calls #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes how the dataloader batching functionality works. Rather than trying to "detect" if a future has a "deferred_callback" in the execution context, we create a singleton `DataLoaderBatchCallbacks` which all dataloaders add their `dispatch_queue` functions to when needed. We can then run all the callbacks in the execution context to complete the SyncFuture's. This allows us to chain dataloaders together. Fixes #6 Diff-Id: daffd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how the dataloader batching functionality works. Rather
than trying to "detect" if a future has a "deferred_callback" in the
execution context, we create a singleton
DataLoaderBatchCallbackswhich all dataloaders add their
dispatch_queuefunctions to whenneeded. We can then run all the callbacks in the execution context to
complete the SyncFuture's. This allows us to chain dataloaders together.
Fixes #6
Diff-Id: daffd