Skip to content

Deprecate custom_parse in favor of custom_func #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Conversation

jf-tech
Copy link
Owner

@jf-tech jf-tech commented Dec 14, 2020

Deprecated but still functional. Simply removed mention of custom_parse from doc and marked it Deprecated in public APIs.

#134

Deprecated but still functional. Simply removed mention of `custom_parse` from doc and marked it `Deprecated` in public APIs.
@jf-tech jf-tech linked an issue Dec 14, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #135 (a779c38) into master (4c56223) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #135   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines         1961      1961           
=========================================
  Hits          1961      1961           
Impacted Files Coverage Δ
extensions/omniv21/ingester.go 100.00% <ø> (ø)
extensions/omniv21/schemahandler.go 100.00% <ø> (ø)
extensions/omniv21/transform/decl.go 100.00% <ø> (ø)
extensions/omniv21/transform/invokeCustomParse.go 100.00% <ø> (ø)
extensions/omniv21/transform/parse.go 100.00% <ø> (ø)
extensions/omniv21/transform/validate.go 100.00% <ø> (ø)
validation/jsonvalidate.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c56223...a779c38. Read the comment docs.

@jf-tech jf-tech merged commit ddd52b9 into master Dec 14, 2020
@jf-tech jf-tech deleted the remove_customparse branch December 14, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge custom_parse into custom_func and retire custom_parse?
1 participant