fix#4805: in single and double quotes

[hajjem-ayoub]

fix for #4805

[vendethiel]

have you tried \\\"coffee-script\\\" and confirm it works on both platforms?

[meetkabeershah]

@hajjem-ayoub Does it works on your local with this fix?

[hajjem-ayoub]

yes tried it only with windows VM, i can also check on mac

[rossanmol]

On mine doesn't work. (Windows 10)

[hajjem-ayoub]

i also tried to npm link it in mac and it seems to work as well, it shows the message correctly at least

[hajjem-ayoub]

@rossanmol just to debug it, can you tell me how did you test it?

[rossanmol]

run node --eval in cmd, might be that it works only with npm postinstall

[rossanmol]

What about this solution:

node --eval "if (require(`./package.json`).name === `coffee-script`) { var red, yellow, cyan, reset; red = yellow = cyan = reset = ``; if (!process.env.NODE_DISABLE_COLORS) { red = `\\x1b[31m`; yellow = `\\x1b[33m`; cyan = `\\x1b[36m`; reset = `\\x1b[0m`; } console.warn(red + `CoffeeScript has moved!` + reset + ` Please update references to ` + yellow + `\\\"coffee-script\\\"` + reset + ` to use ` + yellow + `\\\"coffeescript\\\"` + reset + ` (no hyphen) instead.`); console.warn(`Also, a new major version has been released under the ` + yellow + `coffeescript` + reset + ` name on NPM. This new release targets modern JavaScript, with minimal breaking changes. Learn more at ` + cyan + `http://coffeescript.org` + reset + `.`); console.warn(``); }"

[vendethiel]

@rossanmol people using 1.x not all have access to ES6+ features. That's kinda the point of the 1.x branch.

[hajjem-ayoub]

@rossanmol you cannot use ` you can only use ' or " because es6 not everywhere, but i will try to look for windows 10 to check, but can you tell me how you tested??
did you pull the code and npm linked it??

[rossanmol]

@hajjem-ayoub run the following in cmd:

node --eval \"if (require('./package.json').name === 'coffee-script') { var red, yellow, cyan, reset; red = yellow = cyan = reset = ''; if (!process.env.NODE_DISABLE_COLORS) { red = '\\x1b[31m'; yellow = '\\x1b[33m'; cyan = '\\x1b[36m'; reset = '\\x1b[0m'; } console.warn(red + 'CoffeeScript has moved!' + reset + ' Please update references to ' + yellow + '\\\"coffee-script\\\"' + reset + ' to use ' + yellow + '\\\"coffeescript\\\"' + reset + ' (no hyphen) instead.'); console.warn('Also, a new major version has been released under the ' + yellow + 'coffeescript' + reset + ' name on NPM. This new release targets modern JavaScript, with minimal breaking changes. Learn more at ' + cyan + 'http://coffeescript.org' + reset + '.'); console.warn(''); }\"

I didn't try linking it.

[hajjem-ayoub]

@rossanmol yes but than you don't have process.env.NODE_DISABLE_COLORS

[rossanmol]

@hajjem-ayoub it fails because of the if statement, same as before.

[hajjem-ayoub]

just pushing one like that now :D

[hajjem-ayoub]

@rossanmol and for coloring i used chalk

[vendethiel]

@hajjem-ayoub if anything, you missed a git add.

[hajjem-ayoub]

@vendethiel sorry for that, i amended my commit and push forced again
let me know if i need to add the disable color

[hajjem-ayoub]

@vendethiel done with this and it looks like working fine, i just had to add chalk to dependancies if that's ok

[vendethiel]

I don't think coloring is important enough to warrant adding a dep.

[GeoffreyBooth]

Yes, we don’t have dependencies. I think #4807 is closer to what we need to do.