Skip to content

Use d.Id() on Google Cloud machines #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2022
Merged

Use d.Id() on Google Cloud machines #695

merged 2 commits into from
Oct 14, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Oct 13, 2022 •
edited
Loading

Closes #694; releasing this change may cause a hiccup in some Google Cloud users' runners.

@0x2b3bfa0 0x2b3bfa0 added technical-debt Refactoring, linting & tidying cloud-gcp Google Cloud resource-runner iterative_runner TF resource resource-machine iterative_machine TF resource labels Oct 13, 2022
@0x2b3bfa0 0x2b3bfa0 requested a review from a team October 13, 2022 13:20
@0x2b3bfa0 0x2b3bfa0 self-assigned this Oct 13, 2022
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Oct 13, 2022
Merged
tasdomas
tasdomas approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@tasdomas tasdomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing a significant change like this without it requiring changes to unit tests makes me nervous.

@0x2b3bfa0 0x2b3bfa0 merged commit 7a236ca into master Oct 14, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the gcp-d-id branch October 14, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasdomas tasdomas tasdomas approved these changes

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
cloud-gcp Google Cloud resource-machine iterative_machine TF resource resource-runner iterative_runner TF resource technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use d.Id() instead of d.Get("name") as identifier for Google Cloud
2 participants
@0x2b3bfa0 @tasdomas