Skip to content

run scripts/generate-protos.sh, cover up for PR387 #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

run scripts/generate-protos.sh, cover up for PR387 #395

wants to merge 7 commits into from

Conversation

kidiyoor
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 28, 2018
@istio-testing
Copy link
Collaborator

Hi @kidiyoor. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kidiyoor kidiyoor mentioned this pull request Feb 28, 2018
Merged
ldemailly
ldemailly approved these changes Feb 28, 2018
View reviewed changes
Copy link
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ldemailly
Copy link
Member

proper fix for #394 / #387
/lgtm
will merge when 2nd (placebo) build passes. cc @douglas-reid

@ldemailly
Copy link
Member

/hold
looks like #396 has a more complete fix

@geeknoid
Copy link
Contributor

I don't think we need this anymore.

@geeknoid geeknoid closed this Mar 21, 2018
incfly pushed a commit to incfly/api that referenced this pull request Jun 13, 2018
@mtakigiku @lizan
jwt-auth: support JWK public keys (istio#395)
86386c5
incfly pushed a commit to incfly/api that referenced this pull request Jun 13, 2018
@istio-testing @istio-merge-robot
Update_Dependencies (istio#395)
9058284 
Automatic merge from submit-queue.

[DO NOT MERGE] Auto PR to update dependencies of mixerclient

This PR will be merged automatically once checks are successful.
```release-note
none
```
nacx pushed a commit to nacx/api that referenced this pull request Apr 15, 2020
@tetrate-ci
Implement Liaison v1alpha API handlers (for real this time) (istio#395)
26ed960 
Mirrored from https://github.com/tetrateio/tetrate @ 33caa50346686605619682e68158461194487cd8
nacx pushed a commit to nacx/api that referenced this pull request Feb 23, 2022
@psinghal20
Extend install api to support XCP config protection (istio#395)
5917f9a 
* feat: extend install api to add support for xcp config protection

Signed-off-by: Pratyush Singhal <[email protected]>

* chore: add comments in configProtection fields

Signed-off-by: Pratyush Singhal <[email protected]>

* docs: add user example for xcp config protection configuration

Signed-off-by: Pratyush Singhal <[email protected]>

* docs: update example of config protection configuration

Signed-off-by: Pratyush Singhal <[email protected]>

* refactor: extract configProtection in a separate package shared between install apis and documentation

Signed-off-by: Pratyush Singhal <[email protected]>

* chore: add bazel build files for common package

Signed-off-by: Pratyush Singhal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldemailly ldemailly ldemailly approved these changes

@rshriram rshriram Awaiting requested review from rshriram

@ZackButcher ZackButcher Awaiting requested review from ZackButcher

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kidiyoor @istio-testing @ldemailly @geeknoid @googlebot