[SYCL][libdevice] Move common group utils from sanitizer specific header #18502
+37
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors group utility functions in the libdevice library by moving common group utilities from the sanitizer-specific header into a dedicated header file.
- Removed definitions of WorkGroupLinearId, SubGroupLinearId, and SubGroupBarrier from sanitizer_defs.hpp
- Added a new header group_utils.hpp that contains the common group utility function definitions
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| libdevice/include/sanitizer_defs.hpp | Removed group utility function definitions and added an include for group_utils.hpp |
| libdevice/include/group_utils.hpp | New header containing group utility functions previously defined in sanitizer_defs.hpp |
Files not reviewed (1)
- libdevice/cmake/modules/SYCLLibdevice.cmake: Language not supported
libdevice/include/group_utils.hpp
Outdated
|
|
||
| #if defined(__SPIR__) || defined(__SPIRV__) | ||
|
|
||
| size_t WorkGroupLinearId() { |
There was a problem hiding this comment.
Consider marking these utility functions as 'inline' to avoid potential multiple definition issues if this header is included in multiple translation units.
Suggested change
| size_t WorkGroupLinearId() { | |
| inline size_t WorkGroupLinearId() { |
Copilot uses AI. Check for mistakes.
yingcong-wu
approved these changes
May 16, 2025
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
aelovikov-intel
approved these changes
May 16, 2025
|
Hi, @intel/llvm-gatekeepers |
|
Hi, @intel/llvm-gatekeepers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We defined some group/subgroup util functions in device sanitizer specific headers, these functions will be used by other libdevice functions, so move them to a separate header.