Skip to content

[SYCL][Graph]Fix coverity issues by passing shared pointer by reference. #18473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025

Conversation

fabiomestre
Copy link
Contributor

@fabiomestre fabiomestre commented May 14, 2025

Changes some functions in the sycl graph implementation to pass shared pointers by reference instead of by value.

Fixes: #18412

@fabiomestre fabiomestre force-pushed the fabio/fix_coverity branch from 3ff8738 to b85e029 Compare May 14, 2025 17:33
@fabiomestre fabiomestre force-pushed the fabio/fix_coverity branch from b85e029 to 4aee6ce Compare May 14, 2025 17:40
@fabiomestre fabiomestre force-pushed the fabio/fix_coverity branch from 4aee6ce to 0e74543 Compare May 14, 2025 18:11
@fabiomestre fabiomestre marked this pull request as ready for review May 14, 2025 18:29
@fabiomestre fabiomestre requested a review from a team as a code owner May 14, 2025 18:29
@fabiomestre fabiomestre requested a review from reble May 14, 2025 18:29
Copy link
Contributor

@reble reble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. minor nit.

@EwanC EwanC changed the title Fix coverity issues by passing shared pointer by reference. [SYCL][Graph]Fix coverity issues by passing shared pointer by reference. May 16, 2025
@fabiomestre
Copy link
Contributor Author

@intel/llvm-gatekeepers this PR is ready to merge.

@kbenzie kbenzie merged commit ff0a7ac into intel:sycl May 19, 2025
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Coverity] Variable copied when it could be moved
3 participants