[SYCL] Change pattern to reflect the change in sycl-ls

[bso-intel]

In intel/llvm#3611, I changed the device type to lower case which was necessary to show the SYCL_DEVICE_FILTER prefix for each device listing from sycl-ls.
It caused several tests failures that expected 'GPU' instead of 'gpu'.

Signed-off-by: Byoungro So [email protected]

[smaslov-intel]

Why can't we make this, and other fields of SYCL_DEVICE_FILTER not case-sensitive?

[bso-intel]

Why can't we make this, and other fields of SYCL_DEVICE_FILTER not case-sensitive?

Currently, the implementation of std::ostream device_filter::operator<<() prints only lower-cases.
Users can set SYCL_DEVICE_FILTER whatever cases they want, but our test only look for specific patterns from the sycl-ls print output.
So, to make these tests pass, I had to change the pattern to lower cases.

[smaslov-intel]

Why can't we make this, and other fields of SYCL_DEVICE_FILTER not case-sensitive?

Currently, the implementation of std::ostream device_filter::operator<<() prints only lower-cases.
Users can set SYCL_DEVICE_FILTER whatever cases they want, but our test only look for specific patterns from the sycl-ls print output.
So, to make these tests pass, I had to change the pattern to lower cases.

I mean I'd like to see a RT change to accept upper-case values instead of this change.

[bso-intel]

Why can't we make this, and other fields of SYCL_DEVICE_FILTER not case-sensitive?

Currently, the implementation of std::ostream device_filter::operator<<() prints only lower-cases.
Users can set SYCL_DEVICE_FILTER whatever cases they want, but our test only look for specific patterns from the sycl-ls print output.
So, to make these tests pass, I had to change the pattern to lower cases.

I mean I'd like to see a RT change to accept upper-case values instead of this change.

Yes, RT accepts upper-case values (or any combination works).
But, when we print device filter, we only print the device type in lower case, which was used in sycl-ls.

Please note that this test is only trying to match the string pattern that 'sycl-ls' prints.
It is not testing what string SYCL_DEVICE_FILTER is accepting.

[vladimirlaz]

Why this line was moved? It does not look like intended change,

[bso-intel]

I did refactoring of get_devices(), and it returns CPU devices after GPU devices.

[bso-intel]

@vladimirlaz ,
Could you merge this PR as soon as possible since intel/llvm#4247 is already merged?