Skip to content

Bump nixpkgs pins #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 16, 2025
Merged

Bump nixpkgs pins #2354

merged 16 commits into from
May 16, 2025

Conversation

hamishmack
Copy link
Collaborator

No description provided.

@nrdxp
Copy link

nrdxp commented May 13, 2025

I have found that hadrianEvalPackages has been removed in the upstream nixpkgs GHC package def, and confirmed it is no longer present in your unstable bump in this PR as well.

I have found that removing this override is enough to fix it, but not sure the best way to gracefully include that here, since you want to support both stable and unstable.

'')).override { hadrianEvalPackages = config.evalPackages; };

@hamishmack
Copy link
Collaborator Author

I have found that hadrianEvalPackages has been removed in the upstream nixpkgs GHC package def,

I don't think it ever had it. I'm not sure how it build hadrian. The hadrianEvalPackages is for haskell.nix to use when it makes a plan for building hadrian.

I have found that removing this override is enough to fix it

Do you have an example of how to reproduce the issue? I'm wondering if it is related to using GHCJS 8.10.7 (that might not take the hadrianEvalPackages override).

@nrdxp
Copy link

nrdxp commented May 15, 2025

I don't think it ever had it. I'm not sure how it build hadrian. The hadrianEvalPackages is for haskell.nix to use when it makes a plan for building hadrian.

I was not aware of that, but it makes sense, thanks for clarifying.

Do you have an example of how to reproduce the issue? I'm wondering if it is related to using GHCJS 8.10.7 (that might not take the hadrianEvalPackages override).

Our current stack is fairly complex, but I'll see if I can narrow it down to a minimal reproduction and report back.

@hamishmack hamishmack merged commit 008e8cc into master May 16, 2025
1584 of 1590 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants