feat: added ht-status-display component #1775
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1775 +/- ##
==========================================
- Coverage 83.58% 83.56% -0.02%
==========================================
Files 893 897 +4
Lines 19259 19291 +32
Branches 2663 2667 +4
==========================================
+ Hits 16098 16121 +23
- Misses 3024 3033 +9
Partials 137 137
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Unit Test Results 4 files 300 suites 23m 59s ⏱️ Results for commit 3f08e90. |
projects/observability/src/shared/components/status-display/status-display.component.scss
Show resolved
Hide resolved
| @Input() | ||
| public statusMessage?: string; | ||
|
|
||
| // TODO: Add display for different styles if required |
There was a problem hiding this comment.
@arjunlalb @adisreyaj
We have this component as gray background and since we want this to be used at the status table cell renderer (which has different styling according to the status), how do we wanna approach this?
- Should we replace that styling with this new one
- Or add that styling as a config here as well?
There was a problem hiding this comment.
We should use a single style. I recommend using the existing style. After consulting with design team, we can switch it over to the new one or keep the old one.
There was a problem hiding this comment.
I agree on keeping the same styling throughout the product and yeah, the existing one seems better to me as well. But let's wait for @adisreyaj to comment on this since I think he has more context around that.
I think, We can leave this here as it is until we get final confirmation.
|
Please export this as well from |
| */ | ||
| public transform(statusCode: string | number, statusMessage?: string): string { | ||
| let statusDisplayText = displayString(statusCode); | ||
| if (!isNil(statusMessage) && statusMessage !== 'null') { |
There was a problem hiding this comment.
why are we looking for string null here?
Added ht-status-display component