Skip to content

Privacy Policy opening in new tab #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 1, 2022
Merged

Privacy Policy opening in new tab #1769

merged 4 commits into from
Aug 1, 2022

Conversation

chahat99
Copy link
Contributor

Description

PR makes the Privacy policy opens in new tab.

Earlier result:
Privacy policy opens in the same tab

Expected result from this PR:
Privacy policy should open in new tab

Testing

  • Added a spectator query to check whether the Component Parameters are matched.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@chahat99 chahat99 requested a review from a team as a code owner July 29, 2022 10:16
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #1769 (efaaa4b) into main (c31de98) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1769   +/-   ##
=======================================
  Coverage   83.58%   83.58%           
=======================================
  Files         893      893           
  Lines       19257    19259    +2     
  Branches     2663     2663           
=======================================
+ Hits        16096    16098    +2     
  Misses       3024     3024           
  Partials      137      137           
Impacted Files Coverage Δ
...onents/src/navigation/navigation-list.component.ts 89.47% <100.00%> (+0.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@chahat99 chahat99 merged commit 2a0baa0 into main Aug 1, 2022
@chahat99 chahat99 deleted the privacy_new_tab branch August 1, 2022 05:35
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

Unit Test Results

       4 files  ±0     299 suites  ±0   23m 28s ⏱️ +44s
1 064 tests ±0  1 064 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
1 072 runs  ±0  1 072 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2a0baa0. ± Comparison against base commit c31de98.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants