feat: hidden nav link item #1768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1768 +/- ##
=======================================
Coverage 83.58% 83.58%
=======================================
Files 893 893
Lines 19257 19257
Branches 2663 2663
=======================================
Hits 16096 16096
Misses 3024 3024
Partials 137 137
Help us with your feedback. Take ten seconds to tell us how you rate us. |
This comment has been minimized.
This comment has been minimized.
adisreyaj
approved these changes
Jul 28, 2022
arjunlalb
reviewed
Jul 28, 2022
| @@ -10,6 +10,7 @@ export interface NavItemLinkConfig { | |||
| iconSize?: IconSize; | |||
| label: string; | |||
| matchPaths: string[]; // For now, default path is index 0 | |||
| hidden?: boolean; | |||
There was a problem hiding this comment.
would be helpful to add a description about the purpose of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a config to make the nav link item hidden
Testing
Local Testing is done
Checklist: