fix: publish for docker images #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBAhire
requested review from
aaron-steinfeld,
buchi-busireddy and
kotharironak
as code owners
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
=========================================
Coverage 61.65% 61.65%
Complexity 227 227
=========================================
Files 76 76
Lines 1137 1137
Branches 29 29
=========================================
Hits 701 701
Misses 412 412
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
aaron-steinfeld
approved these changes
Jan 7, 2021
| @@ -37,7 +37,7 @@ jobs: | |||
| - name: publish docker image | |||
| uses: hypertrace/github-actions/gradle@main | |||
| with: | |||
| args: publish dockerPushImages | |||
There was a problem hiding this comment.
Because HTC is not currently supported as its own deployment, it may be worth removing the entire publish workflow. Up to you.
There was a problem hiding this comment.
Let's keep it for now. Because if that caught up again then we have to fix it anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
removes publish from gradle publish as this repo doesn't have publish.