Skip to content

fix: bump more package versions in the base docker image #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025

Conversation

SupernaviX
Copy link
Contributor

Proposed changes

Bump the version of two packages in the dockerfile. It looks like builds off of main are broken again because new versions of these packages were released.


Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Screenshots (If Applicable)


Other Information

@SupernaviX SupernaviX requested a review from a team as a code owner May 16, 2025 03:00
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (09d29f8) to head (e1725a0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1683   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         339      339           
  Lines       29782    29782           
=======================================
  Hits        29770    29770           
  Misses          8        8           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SupernaviX SupernaviX mentioned this pull request May 16, 2025
8 tasks
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - we have always pinning really closely versions and this hits us a lot, would be good to see if the OpenSSF scorecard allows us to be more flexible with these

@SupernaviX
Copy link
Contributor Author

@EnriqueL8 I don't seem to have permission to merge this

@EnriqueL8 EnriqueL8 merged commit bbbe443 into hyperledger:main May 19, 2025
19 checks passed
@EnriqueL8
Copy link
Contributor

@SupernaviX You shouldn't have permission to merge

@SupernaviX SupernaviX deleted the bump-more-versions branch May 19, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants