chore(cargo): Update url crate to 0.5 #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failure doesn't seem to be related. I'm not sure. |
|
Perhaps wait for servo/rust-url#138 |
untitaker
force-pushed
the
url-update
branch
from
4534df3 to
78752c0
Compare
untitaker
changed the title
|
This is now review-ready, turns out pinning only by version-range is a bad idea. Anyone? |
|
@untitaker for my own reference, what went wrong with a version range? |
reem
added a commit
that referenced
this pull request
Nov 23, 2015
chore(cargo): Update url crate to 0.5
|
@Ryman Just problems in principle: You might expose different behavior depending on which url version is installed. Some of that behavior differences are catched by the typesystem and the resulting combination just doesn't compile, but others may be more subtle. |
|
BTW: You'd probably have to bump the minor version after this, since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent update in url triggered a version split in my application andbroke my build.
Since hyper is still compatible with 0.2, I think it might make sense tostill allow that version.