Skip to content

fix(tag-pair): point tag-pair error message to correct line and colum… #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bebehr
Copy link
Contributor

@bebehr bebehr commented Feb 20, 2025

…n number

fix #1284

Short description of what this resolves:
Pointing to correct line number in tag-pair message when end tag is missing.

Proposed changes:
Adds lastEvent.line and lastEvent.col to rule check with updated tests.

@bebehr bebehr requested a review from thedaviddias as a code owner February 20, 2025 21:23
@github-actions github-actions bot added core Relates to HTMLHint's core APIs and features test labels Feb 20, 2025
@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Apr 26, 2025
@htmlhint htmlhint deleted a comment from stale bot Apr 27, 2025
@stale stale bot removed the bot:stale Issue marked as stale because there was no activity label Apr 27, 2025
@coliff coliff added the keep-unstale The issue will not be marked as stale by the stale-bot label Apr 27, 2025
@coliff coliff force-pushed the fix/issue-1284 branch from 9db9f1c to 3bed7e8 Compare May 7, 2025 08:37
@coliff coliff mentioned this pull request May 8, 2025
@coliff coliff force-pushed the fix/issue-1284 branch from 3bed7e8 to 4f61cce Compare May 9, 2025 11:16
@coliff coliff self-requested a review May 9, 2025 11:31
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.99%. Comparing base (2c63ab0) to head (aa80fb1).

Files with missing lines Patch % Lines
dist/htmlhint.js 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1503      +/-   ##
==========================================
- Coverage   97.97%   96.99%   -0.99%     
==========================================
  Files           2        2              
  Lines        1627     1628       +1     
  Branches      339      334       -5     
==========================================
- Hits         1594     1579      -15     
- Misses         33       49      +16     
Files with missing lines Coverage Δ
dist/htmlhint.js 96.98% <50.00%> (-0.99%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c63ab0...aa80fb1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Relates to HTMLHint's core APIs and features keep-unstale The issue will not be marked as stale by the stale-bot test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tag-pair points to the wrong line
3 participants