This repository was archived by the owner on Jan 15, 2025. It is now read-only.
WIP: Decoding function parameters from JSON string #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction we need to use the global scope for now
| } | ||
|
|
||
| export function test_decode_multiple_params(encoded_allocation: u32): u32 { | ||
| let jsonString: string = deserialize(encoded_allocation); |
There was a problem hiding this comment.
I got the impression from Max's PR we could/should just leave out the type defs on variable declarations that aren't in the function signature
|
|
||
| class MultiParameterHandler extends Handler { | ||
| onString(value: string): void { | ||
| if(this.currentKey == "firstString") { |
There was a problem hiding this comment.
Could currentKey be passed in as a param to the function itself, rather than being an implicit property on the class?
There was a problem hiding this comment.
Yes I like your idea better. I think I will combine currentKey and keyStack to a single parameter that is passed to each of the value callbacks.
Connoropolous
approved these changes
Sep 27, 2018
willemolding
commented
Sep 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a proposed solution to parsing the parameters to a function passed as a JSON string.
This current implementation only supports primitives and string arguments but extending it to also accept objects and arrays should not be too difficult.
It uses asm-json-parser which is a module I write for event driven JSON parsing in assemblyscript. Using this to define a parser for a custom class is pretty straightforward and most of this boilerplate will be generated by the transform stage.
Inviting feedback and comments before going further
Closes #4