MEDIUM: discovery: Nomad Service Discovery integration #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds models and specifications for Nomad service discovery.
In this PR, I've kept most things similar to Consul. The only differences in
models.Consulandmodels.Nomadare:Renamed
ServiceAllowListtoAllowlist. It's in-line with AWS. As noted in this issue the existing params in consul don't work, so I felt it's better to tweak it here and keep it in-line with AWS discovery module.Used
SecretIDinstead ofToken. Nomad's Go SDK usesSecretIDas the field for passing an ACL Token while Consul usesToken.