Skip to content

Adding getDataLength() #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2020
Merged

Adding getDataLength() #14

merged 3 commits into from
Apr 22, 2020

Conversation

tobozo
Copy link
Contributor

@tobozo tobozo commented Apr 20, 2020

No description provided.

@tobozo tobozo mentioned this pull request Apr 20, 2020
Closed
@h2zero
Copy link
Owner

h2zero commented Apr 20, 2020

I think we should define the function in the cpp file. I know it’s not necessary but it keeps the convention the rest of the library follows.

@tobozo
Copy link
Contributor Author

tobozo commented Apr 20, 2020

for some reason my text editor wants to insert that newline at the end of the files, sorry about that :-)

h2zero
h2zero reviewed Apr 20, 2020
View reviewed changes
Copy link
Owner

@h2zero h2zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@h2zero h2zero merged commit 39a804d into h2zero:master Apr 22, 2020
@h2zero h2zero linked an issue Apr 22, 2020 that may be closed by this pull request
Migrating ESP32-BLECollector #13
Closed
@pletch pletch mentioned this pull request Jan 7, 2021
Closed
@DTTerastar DTTerastar mentioned this pull request Oct 13, 2021
Closed
@Tschmidt9490 Tschmidt9490 mentioned this pull request Jul 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h2zero h2zero h2zero left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrating ESP32-BLECollector
2 participants
@tobozo @h2zero