This repository was archived by the owner on Jun 8, 2021. It is now read-only.
Update for new glib::Value::get
signature
#257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in consequence of gtk-rs/glib#513
For the
Result<_, _>::expect
behaviour, please see the following discussion: gtk-rs/gir#825 (review). TLDR: the argument forexpect
should refer to the context (or the reason why it shouldn't panic), the error will be automatically added in the panic message (using theDebug
trait unfortunately).For the method names, please see: gtk-rs/glib#513 (review) and then gtk-rs/glib#513 (comment). TLDR:
get
allows writing generic code,get_some
is the best name we could think of toget
the actual value for a non-optionalType
without the need tounwrap
anOk
output ofget
.