Skip to content
This repository was archived by the owner on Jun 8, 2021. It is now read-only.

Update for new glib::Value::get signature #257

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Update for new glib::Value::get signature #257

merged 1 commit into from
Aug 12, 2019

Conversation

fengalin
Copy link
Contributor

@fengalin fengalin commented Aug 10, 2019

... in consequence of gtk-rs/glib#513

For the Result<_, _>::expect behaviour, please see the following discussion: gtk-rs/gir#825 (review). TLDR: the argument for expect should refer to the context (or the reason why it shouldn't panic), the error will be automatically added in the panic message (using the Debug trait unfortunately).

For the method names, please see: gtk-rs/glib#513 (review) and then gtk-rs/glib#513 (comment). TLDR: get allows writing generic code, get_some is the best name we could think of to get the actual value for a non-optional Type without the need to unwrap an Ok output of get.

@EPashkin
Copy link
Member

Please, repase it to pending branch and Edit PR

@fengalin fengalin changed the base branch from master to pending August 10, 2019 10:24
@EPashkin
Copy link
Member

@fengalin Thanks

@fengalin fengalin mentioned this pull request Aug 12, 2019
43 tasks
@fengalin
Copy link
Contributor Author

\o/

@sdroege
Copy link
Member

sdroege commented Aug 12, 2019

@GuillaumeGomez looks all good now :)

@GuillaumeGomez
Copy link
Member

Indeed! Thanks @fengalin !

@GuillaumeGomez GuillaumeGomez merged commit 1b627a4 into gtk-rs:pending Aug 12, 2019
@fengalin fengalin deleted the value_get_result branch August 12, 2019 21:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants