Fix Spring native metadata after the add of spring-data-elasticsearch dependency #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinebhs
force-pushed
the
fix-spring-native-metadata
branch
from
154b80a to
e27915d
Compare
After the add of Spel in @value, this error is thrown when starting the service in native: ```Caused by: org.springframework.expression.spel.SpelEvaluationException: EL1004E: Method call: Method getProperty(java.lang.String) cannot be found on type org.springframework.boot.web.servlet.context.ApplicationServletEnvironment at org.springframework.expression.spel.ast.MethodReference.findAccessorForMethod(MethodReference.java:225) ~[na:na] at org.springframework.expression.spel.ast.MethodReference.getValueInternal(MethodReference.java:135) ~[na:na] at org.springframework.expression.spel.ast.MethodReference$MethodValueRef.getValue(MethodReference.java:380) ~[na:na] at org.springframework.expression.spel.ast.CompoundExpression.getValueInternal(CompoundExpression.java:96) ~[na:na] at org.springframework.expression.spel.ast.SpelNodeImpl.getTypedValue(SpelNodeImpl.java:119) ~[org.gridsuite.directory.server.DirectoryApplication:6.0.11] at org.springframework.expression.spel.standard.SpelExpression.getValue(SpelExpression.java:309) ~[na:na] at org.springframework.expression.common.CompositeStringExpression.getValue(CompositeStringExpression.java:108) ~[na:na] at org.springframework.expression.common.CompositeStringExpression.getValue(CompositeStringExpression.java:121) ~[na:na] at org.springframework.data.elasticsearch.core.mapping.SimpleElasticsearchPersistentEntity.resolve(SimpleElasticsearchPersistentEntity.java:353) ~[org.gridsuite.directory.server.DirectoryApplication:5.1.2] at org.springframework.data.elasticsearch.core.mapping.SimpleElasticsearchPersistentEntity.resolve(SimpleElasticsearchPersistentEntity.java:335) ~[org.gridsuite.directory.server.DirectoryApplication:5.1.2] at org.springframework.data.elasticsearch.core.mapping.SimpleElasticsearchPersistentEntity.getIndexCoordinates(SimpleElasticsearchPersistentEntity.java:134) ~[org.gridsuite.directory.server.DirectoryApplication:5.1.2] at org.springframework.data.elasticsearch.client.elc.IndicesTemplate.getIndexCoordinatesFor(IndicesTemplate.java:450) ~[na:na] at org.springframework.data.elasticsearch.client.elc.IndicesTemplate.getIndexCoordinates(IndicesTemplate.java:446) ~[na:na] at org.springframework.data.elasticsearch.client.elc.IndicesTemplate.exists(IndicesTemplate.java:169) ~[na:na] at org.springframework.data.elasticsearch.repository.support.SimpleElasticsearchRepository.<init>(SimpleElasticsearchRepository.java:83) ~[org.gridsuite.directory.server.DirectoryApplication:5.1.2] at [email protected]/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) ~[org.gridsuite.directory.server.DirectoryApplication:na] at [email protected]/java.lang.reflect.Constructor.newInstance(Constructor.java:480) ~[org.gridsuite.directory.server.DirectoryApplication:na] at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:211) ~[na:na] ... 81 common frames omitted``` Adding the missing method named in the stacktrace to metadata fix this issue.
antoinebhs
force-pushed
the
fix-spring-native-metadata
branch
from
e27915d to
14f3eb4
Compare
|
EstherDarkish
approved these changes
Mar 4, 2024
antoinebhs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Documentannotation:directory-server/src/main/java/org/gridsuite/directory/server/dto/elasticsearch/DirectoryElementInfos.java
Line 29 in 91468f3
The following error is thrown when starting the service in native:
Adding the missing method named in the stacktrace to metadata fix this issue. This issue is mentioned spring-projects/spring-boot#34206 (where they suggest to add RuntimeHints as in this PR) and spring-projects/spring-framework#29548
_DESERIALIZERis not necessary in recent versions ofspring-data-elasticsearch, this was fixed in May 2023: Extend AOT runtime hints. spring-projects/spring-data-elasticsearch#2579 (related issue AOT/GraalVM/native Caused by: java.lang.RuntimeException: No deserializer found in 'co.elastic.clients.elasticsearch.indices.IndexSettings._DESERIALIZER' spring-projects/spring-data-elasticsearch#2565)