-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs: add linting and code snippet validation #1983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add linting and code snippet validation #1983
Conversation
@sarahxsanders is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! I'm going to integrate some of the improvements here into my own software! 😁
I've left some small suggested tweaks below, but only 2 are potential blockers: the concern about adding a new page and linking to it from existing pages, and the one where operation
is changed to mutation
@benjie added a commit to build locally for link checking |
hey @benjie just bumping this one for review! |
I pushed up a commit @sarahxsanders hopefully that fixes failing builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI seems to be passing for our existing actions. We can't really run the new CI jobs from this PR so once we merge will have to see how they do it
@saihaj feel free to merge this whenever for me! :) I don't have merge permissions (may need to get these for the rest of my incoming PRs as I open them) |
Description
This PR introduces linting and code snippet validation for GraphQL snippets. JS snippets are commented out on this PR, because I will modernize the JS code snippets first.
Changes
validate-snippets.js
script that extracts code snippets from MDX files and validates them against parsers. Note, I temporarily commented out JS validation logic until those code snippets are modernized to meet the latest standards.<!-- snippet-ignore -->
for GQL snippets causing errorsComments
Review