Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Voyager configuration options #600

Merged
merged 7 commits into from
May 2, 2021
Merged

Voyager configuration options #600

merged 7 commits into from
May 2, 2021

Conversation

setchy
Copy link
Member

@setchy setchy commented May 1, 2021

  • Standardizing basePath to match playground and altair tools
  • Support all of the common Voyager configuration options via properties
  • Adding README entry to document Voyager and the configuration options available

@setchy setchy added this to the 11.1.0 milestone May 1, 2021
@setchy setchy self-assigned this May 1, 2021
@setchy setchy linked an issue May 1, 2021 that may be closed by this pull request
@BlasiusSecundus
Copy link

I suggest to externalise all properties to a @ConfigurationProperties class.

  • I think this would result in cleaner code
  • Auto-completion in some IDE-s (e. g. IntelliJ Ultimate) for the properties using metadata automatically generated by spring-boot-configuration-processor (javadoc comments will also be picked up as descriptions)
  • perhaps this class can also be configured using jackson so that it can be easily mapped to the needed replacements structure by jackson instead of manually composing the map

@setchy
Copy link
Member Author

setchy commented May 1, 2021

Sure thing @BlasiusSecundus. I've made an update, modelling it off the way GraphQL Playground autoconfigure is working

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 1, 2021

@setchy setchy merged commit b6cee6a into master May 2, 2021
@setchy setchy deleted the feature/voyager-latest branch May 9, 2021 12:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voyager missing change introspection feature
2 participants