This repository was archived by the owner on Dec 19, 2023. It is now read-only.
Only call GraphqlErrorBuilder with non-null data #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods on GraphqlErrorBuilder each contain [an assertion that the supplied data is non-null](https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/GraphqlErrorBuilder.java#L77), but it is not required that these elements be non-null on every throw GraphQLError. For example, errors often omit a `path` property, which will lead to an unhandled `graphql.AssertException` when the error is handled by `GraphQLErrorFromExceptionHandler.java`.
jeskew-gov
force-pushed
the
allow-errors-with-null-paths
branch
from
2bf3698 to
6d73ea0
Compare
jeskew-gov
force-pushed
the
allow-errors-with-null-paths
branch
from
6d73ea0 to
140d935
Compare
|
Thanks for your contribution, @jeskew-gov ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods on GraphqlErrorBuilder each contain an assertion that the supplied data is non-null, but it is not required that these elements be non-null on every throw GraphQLError. For example, errors often omit a
pathproperty, which will lead to an unhandledgraphql.AssertExceptionwhen the error is handled byGraphQLErrorFromExceptionHandler.java.At present, type coercion errors always result in a HTTP response with an empty body and a 400 response code due to the way graphql-java normalizes
CoercingParseValueExceptions