This repository was archived by the owner on Dec 19, 2023. It is now read-only.
fix: GraphQLTestSubscription test failing #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also includes some minor fixes and improvements to GraphQLTestSubscription behaviour. Apparently, there were several potential causes of failure on the pipeline: - the web socket connection was not properly closed after certain tests (reset was not called after tests) - web socked connection timed out (solved by increasing connection timeout) - value of "acknowledged" could be true after reset (init method now waits for the "acknowledged" message to arrive) - "responses" may not be empty after reset (solved by making clear call synchronized)
|
Thanks @BlasiusSecundus ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some minor fixes and improvements to
GraphQLTestSubscription behaviour.
Apparently, there were several potential causes of failure on the
pipeline:
(reset was not called after tests)
timeout)
waits for the "acknowledged" message to arrive)
synchronized)