Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Enable or disable async mode #540

Closed
oliemansm opened this issue Feb 21, 2021 · 0 comments · Fixed by #541
Closed

Enable or disable async mode #540

oliemansm opened this issue Feb 21, 2021 · 0 comments · Fixed by #541
Milestone

Comments

@oliemansm
Copy link
Member

After the refactor of async mode support the possibility to configure async support has been removed entirely. This should be reinstated, while still keeping the new way of checking it using the HttpServletRequest itself, e.g.

public ServletRegistrationBean dispatcherServlet() {
    ServletRegistrationBean registration = new ServletRegistrationBean(new DispatcherServlet(), "/");
    registration.setAsyncSupported(true);
    return registration;
}

The old property should be made available again too, but now it will be true by default. So to disable it you'd have to add the following property:

graphql.servlet.async-mode-enabled: false
@oliemansm oliemansm added this to the 11.1.0 milestone Feb 21, 2021
@oliemansm oliemansm linked a pull request Feb 21, 2021 that will close this issue
oliemansm added a commit that referenced this issue Feb 21, 2021
Reinstate the async mode enabled property fix #540
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant